search

kvesteri / sqlalchemy-utils

Various utility functions and datatypes for SQLAlchemy.
Other
1.26k stars 321 forks source link

PhoneNumberType default character width too small #228

Open 3noch opened 8 years ago

3noch commented 8 years ago

https://github.com/kvesteri/sqlalchemy-utils/blob/master/sqlalchemy_utils/types/phone_number.py#L155

Some phone numbers have extensions and will cause this 20-character width to be violated.

kurtmckee commented 2 years ago

Closing because the code has changed and the issue has been resolved.

kurtmckee commented 2 years ago

Oh, I see now what you were referring to. The link to the master branch happened to point to a docstring line with a 255 character column definition.

Can you provide an example of a phone number with an extension that is longer than 20 characters?

3noch commented 2 years ago

6 years later I no longer have access to that information. But I am confident I stumbled on this with real data.

kurtmckee commented 2 years ago

I believe it! I've started contributing to the project recently and I'm working through phone number-related tickets, so I'm seeing this very belatedly.

I'll keep this open a bit longer and try to construct some examples for unit testing.