search

kvetak / RINA

RINA Simulator
https://rinasim.omnetpp.org/
Other
29 stars 12 forks source link

Undeclared signal "Routing-Update" emitted (@signal missing from NED file?). #19

Closed gaixas1 closed 7 years ago

kvetak commented 7 years ago

Hi, Sergio!

I have fixed missing declaration of signal and this particular error should be fixed in the current master https://github.com/kvetak/RINA/commit/e4679e79396f9a144ac7f78252915bf6fb31aadb. Since I am not an author of any Routing example, I would like to ask you to check, whether scenarios behave OK.

So far I have found bug in /examples/Routing/DDC in your module FlowListener which is casting error related to the object contained in the signal.

I will coordinate with @kjerabek checking of DAF configuration in order to have example fully compatible with the new RINASim.

kvetak commented 7 years ago

Kamile @kjerabek ! I kindly ask you to check (and if possible repair) DAF components configuration in following scenarios:

/examples/Routing/BigDC /examples/Routing/FatTreeTopology /examples/Routing/RCoreNet /examples/Routing/UnreliableLinks /examples/Routing/LatEx

Use some previous version of RINASim as the baseline where these examples seem to work.

gaixas1 commented 7 years ago

Some of these examples should be corrected (or deleted) as the version in sim is old now when pulling my branch into master (all data injection and similar has been changed there and examples modified)

2016-11-17 13:08 GMT+01:00 Vladimir Vesely notifications@github.com:

Kamile @kjerabek https://github.com/kjerabek ! I kindly ask you to check (and if possible repair) DAF components configuration in following scenarios:

/examples/Routing/BigDC /examples/Routing/FatTreeTopology /examples/Routing/RCoreNet /examples/Routing/UnreliableLinks /examples/Routing/LatEx

Use some previous version of RINASim as the baseline where these examples seem to work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kvetak/RINA/issues/19#issuecomment-261231109, or mute the thread https://github.com/notifications/unsubscribe-auth/ABY86ASOgWCzetCB7sM7uoYkHK5b-1SLks5q_EO_gaJpZM4KrgsH .

gaixas1 commented 7 years ago

I will check it, but better after mergin my changes into master (some examples already corrected there) and most "extra" code modified.

2016-11-17 13:04 GMT+01:00 Vladimir Vesely notifications@github.com:

Hi, Sergio!

I have fixed missing declaration of signal and this particular error should be fixed in the current master e4679e7 https://github.com/kvetak/RINA/commit/e4679e79396f9a144ac7f78252915bf6fb31aadb. Since I am not an author of any Routing example, I would like to ask you to check, whether scenarios behave OK.

So far I have found bug in /examples/Routing/DDC in your module FlowListener which is casting error related to the object contained in the signal.

I will coordinate with @kjerabek https://github.com/kjerabek checking of DAF configuration in order to have example fully compatible with the new RINASim.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kvetak/RINA/issues/19#issuecomment-261230292, or mute the thread https://github.com/notifications/unsubscribe-auth/ABY86EdC3a3uRcDA1HAWeK15gXKYW7VDks5q_EK3gaJpZM4KrgsH .

kvetak commented 7 years ago

Okay, I will merge it right now, after I successfully compile it and test few Demos at my computer.

kvetak commented 7 years ago

@gaixas1 You can continue in master branch, I have successfully merged your contribution into master. As soon as you will tell me that everything is okay from your perspective, we will create a new fingerprints and tag that RINASim version for your convenience of future referencing.

gaixas1 commented 7 years ago

ok

2016-11-17 14:18 GMT+01:00 Vladimir Vesely notifications@github.com:

@gaixas1 https://github.com/gaixas1 You can continue in master branch, I have successfully merged your contribution into master. As soon as you will tell me that everything is okay from your perspective, we will create a new fingerprints and tag that RINASim version for your convenience of future referencing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kvetak/RINA/issues/19#issuecomment-261244160, or mute the thread https://github.com/notifications/unsubscribe-auth/ABY86JB0BR9FhUj2yL5rt8HbQpetQDQ9ks5q_FQmgaJpZM4KrgsH .

kjerabek commented 7 years ago

Hi, I checked scenarios you mentioned.

/examples/Routing/LatEx

/examples/Routing/RCoreNet

/examples/Routing/BigDC

/examples/Routing/FatTreeTopology

kvetak commented 7 years ago

I consider this issue as resolved, thus, I am closing it. Generally, in NED files there are still some leftovers of intentionally commented signals. The reason is that with migration towards OMNeT++ 5.0 where signal checking is mandatory, we wanted to double-check existing signals (and get rid off unused ones).

So anytime in the future when you receive Undeclared signal error, inspect parent NED file first. Related link to this issue https://omnetpp.org/9-articles/software/3713-omnet-441-released .