There are a lot of cosmetic changes in this PR, but also some things that are necessary for the Ethernet shim DIF. The commits in question are 676c98e and e7f20eb.
Read the corresponding commit messages (press the ellipsis next to the commits) to see an explanation. My thesis contains a more complete explanation of why the connection status check is required.
The changes marked "refactor" do not make execution flow changes to the code, only rearranges code and removes some signals that obfuscate the meaning of the code. This is just a small dent, as some of the uses of signals have you go through 3-4 files before you end up in the function the signal is supposed to trigger, and this was a pain when first trying to understand the codebase. I imagine it will also be problematic for the next person who implements a shim DIF of another type, so I changed a little bit to make the code slightly more readable.
This is just a patch added (git add --patch) version of parts of this repo: https://github.com/karlhto/RINA-thesis
Check it out for proper commit dates. :)
There are a lot of cosmetic changes in this PR, but also some things that are necessary for the Ethernet shim DIF. The commits in question are 676c98e and e7f20eb.
Read the corresponding commit messages (press the ellipsis next to the commits) to see an explanation. My thesis contains a more complete explanation of why the connection status check is required.
The changes marked "refactor" do not make execution flow changes to the code, only rearranges code and removes some signals that obfuscate the meaning of the code. This is just a small dent, as some of the uses of signals have you go through 3-4 files before you end up in the function the signal is supposed to trigger, and this was a pain when first trying to understand the codebase. I imagine it will also be problematic for the next person who implements a shim DIF of another type, so I changed a little bit to make the code slightly more readable.
This is just a patch added (
git add --patch) version of parts of this repo: https://github.com/karlhto/RINA-thesis Check it out for proper commit dates. :)