search

kvetak / RINA

RINA Simulator
https://rinasim.omnetpp.org/
Other
29 stars 11 forks source link

Usage of stale MaxSeqNumRcvd #4

Closed vmaffione closed 9 years ago

vmaffione commented 9 years ago

Hi, In function DTP::handleDataTransferPDUFromRmtnew(), line 681 - branch master - I see that you use state.getMaxSeqNumRcvd(), but the MaxSeqNumRcvd variable seems not to be used anymore, so basically it's always 0. May be you meant state.setRcvLeftWinEdge(pdu->getSeqNum()) ?

Cheers, Vincenzo

screw commented 9 years ago

Hello Vincenzo. Thank you for pointing out that mistake. It will be fixed in the next commit.

Best, m&M.