search

kvh / recurrent

Natural language parsing of dates and recurring events
MIT License
249 stars 30 forks source link

Implement COUNT, BYSETPOS, BYWEEKNO, EXDATE, EXRULE, and format() #20

Closed snoopyjc closed 4 years ago

snoopyjc commented 4 years ago

Implement COUNT, BYSETPOS, BYWEEKNO, EXDATE, EXRULE, and new deparse (now format) method. Fix Issue #12. Update tests for 100% code coverage.

kvh commented 4 years ago

Amazing work, great to see expanded tests at 100% coverage, plus the "deparse" bonus functionality. Very cool. I prefer "format" over "deparse", in accordance with the strftime strptime convention. Otherwise LGTM

snoopyjc commented 4 years ago

Ok I’ll push that name change.

-joe Sent from my AT&T iPhone

On Aug 24, 2020, at 12:04 AM, Ken Van Haren notifications@github.com wrote:

 Amazing work, great to see expanded tests at 100% coverage, plus the "deparse" bonus functionality. Very cool. I prefer "format" over "deparse", in accordance with the strftime strptime convention. Otherwise LGTM

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

snoopyjc commented 4 years ago

Ok - it's all set!

kvh commented 4 years ago

You added some .swp files in that last commit. Remove and add to .gitignore?

snoopyjc commented 4 years ago

Sorry - stuff left by my editor - fixed!!

kvh commented 4 years ago

Live: https://pypi.org/project/recurrent/0.4.0/

snoopyjc commented 4 years ago

Thanks! The 2 open issues can now be closed.