kvij / scuttle

A wrapper for applications to help with running Istio Sidecars
MIT License
9 stars 4 forks source link

Add quit request timeout #18

Closed kvij closed 1 year ago

kvij commented 1 year ago

To ensure scuttle does not hang on sending quit requests (especially relevant if also providing a generic quit endpoint) a timeout can be provided. When a request fails or times out, it is logged (if enabled) but scuttle will exit cleanly and timely. By default, the QUIT_REQUEST_TIMEOUT is set to 5 seconds.

When multiple generic quit endpoints are provided they are now called in parallel to ensure the timeout is guaranteeing a quick shutdown of scuttle.