search

kvirc / KVIrc

The KVIrc IRC Client
http://www.kvirc.net/
GNU General Public License v2.0
240 stars 75 forks source link

Settings: include styleName in font; fix #2567 #2568

Closed ctrlaltca closed 10 months ago

ctrlaltca commented 10 months ago

KviStringConversion: is used to convert a font from/to a string for settings storage. This PR adds "styleName" to the font properties saved in the settings file. This property is needed by QFontDialog to show the correct font style (eg. italic, bold, etc) for certain fonts. One example of this font is MS' Verdana, that includes localized version for the style names.

DarthGandalf commented 10 months ago

This does help... as long as user doesn't change the system locale. Because the localized string "Курсив"/"Italic" is saved in settings. When I flip between different LC_ALL, I see the same behavior as without this fix.

I guess that's still better than what we have now :(

ctrlaltca commented 10 months ago

Correct, as long as the font uses localized style names there's no way we can support switching locales.