NSIS: make the installer wait for the uninstall to finish before proceeding; fix #2546

kvirc / KVIrc

The KVIrc IRC Client

http://www.kvirc.net/

GNU General Public License v2.0

240 stars 75 forks source link

NSIS: make the installer wait for the uninstall to finish before proceeding; fix #2546 #2619

Closed ctrlaltca closed 6 months ago

ctrlaltca commented 6 months ago

We used ExecWait to run the uninstaller, that should already wait for the process to finish. By default the NSIS uninstaller copies itself to a temp directory and runs itself again from inside that dir. This caused the ExecWait to return early. This PR disabled this default behavior and replicates it so that we ExecWait the correct uninstaller process.