kvirc / KVIrc

The KVIrc IRC Client
http://www.kvirc.net/
GNU General Public License v2.0
232 stars 76 forks source link

Fix Wayland window associations #2621

Closed ReillyBrogan closed 3 months ago

ReillyBrogan commented 3 months ago

Wayland uses the appId/desktopFileName window property to associate windows to the desktop launcher. 6dc728d2aeae3da55120270729ce9358a1e9537b renamed the .desktop launcher from kvirc.desktop to net.kvirc.KVIrc${CMAKE_KVIRC_VERSION_MAJOR}.desktop, however the desktopFileName window property was still being set to kvirc causing Wayland compositors to not correctly associate windows if they were behaving in a FreeDesktop specification compliant way (note that GNOME is not FreeDesktop-compliant here as they also use the StartupWMClass property from the .desktop to match with .desktop launchers as well as the filename).

On KDE Plasma 5 and 6 this would manifest in the following ways:

This fixes all of those cases.

ctrlaltca commented 3 months ago

Thank you for the PR and the nice explanation of the problem.