Closed ctrlaltca closed 3 months ago
@DarthGandalf i don't expect a real review on this PR, but id' be curious to know your opinion on dropping dcc video vs keeping it minimally upgraded but disabled by default.
I stopped using DCC many years ago. There are better FOSS videoconferencing solutions. If you want to drop it, I won't stop you.
This PR adapts the code to the Qt6 API, dropping Qt5 support.
IMHO, check for WANT_DCC_VIDEO must be with QT6 only:
--- CMakeLists.txt.orig 2024-05-11 11:44:18 UTC
+++ CMakeLists.txt
@@ -938,6 +938,7 @@ endif()
# DCC video support + extended webcam support (LibV4L2)
############################################################################
+if(${QT_VERSION_MAJOR} EQUAL 6)
option(WANT_DCC_VIDEO "Compile DCC video support" OFF)
if(WANT_DCC_VIDEO)
@@ -955,6 +956,11 @@ if(WANT_DCC_VIDEO)
else()
set(COMPILE_DISABLE_DCC_VIDEO 1)
set(CMAKE_STATUS_DCC_VIDEO_SUPPORT "No")
+endif()
+
+else()
+ set(COMPILE_DISABLE_DCC_VIDEO 1)
+ set(CMAKE_STATUS_DCC_VIDEO_SUPPORT "Not available (Qt 6 required)")
endif()
############################################################################
Dcc video has never been in an usable state, and it still isn't. This PR adapts the code to the Qt6 API, dropping Qt5 support. It should now be working on every OS supported by Qt. There are still a lot of things that would need to be done, eg:
To be honest i don't use any DCC anymore, let alone dcc video. In a world of NAT-ted devices, better technologies exists to accomplish this. No need to reinvent the wheel this time. Still, we either drop dcc video completely or keep it working enough to justify its existence.