Add cmake option WANT_PERL_DOCS to disable doc generation.

kvirc / KVIrc

The KVIrc IRC Client

http://www.kvirc.net/

GNU General Public License v2.0

232 stars 76 forks source link

Closed ctrlaltca closed 2 months ago

ctrlaltca commented 2 months ago

Also:

ensure Qt version is reported correctly by cmake.
KviApplication::checkGlobalKvircDirectory: don't test for help subdir (it may not exist if WANT_PERL_DOCS=off)
Cmake: use the imported target for Threads instead of CMAKE_THREAD_LIBS_INIT Fix #2634

VVD commented 2 months ago

Your patch for PERL options (https://github.com/kvirc/KVIrc/pull/2635/commits/4d6af2e64e0f416c18eb8d72fdca081831aad672) is better than mine - can build with perl scripting without documentation, but with my patch it's impossible. But your patch for Threads (https://github.com/kvirc/KVIrc/pull/2635/commits/2b4af7b12ae6e46f1c8f68f43d7e7f71501384ca) doesn't work - same link error.

ctrlaltca commented 2 months ago

But your patch for Threads (2b4af7b) doesn't work - same link error.

VVD commented 2 months ago

But your patch for Threads (2b4af7b) doesn't work - same link error.

Can you please test adding 03fb5fb ?

With both patches build without errors.