search

kvirc / KVIrc

The KVIrc IRC Client
http://www.kvirc.net/
GNU General Public License v2.0
232 stars 76 forks source link

Set portable when it is needed on windows #2638

Closed DoumanAsh closed 2 months ago

DoumanAsh commented 2 months ago

This moves portable file check outside of application ctor to avoid QApplication weird behavior

Previously on my system (Windows 10) with version 5.2.2, KVirc was unable to detect portable file correctly With this change, it is now able to correctly determine it

The most likely reason is that you can only call applicationDirPath outside of ctor

Fixes #2637

DoumanAsh commented 2 months ago

I'm not sure what is wrong with mac os build:

[100%] Building CXX object src/modules/spellchecker/CMakeFiles/kvispellchecker.dir/libkvispellchecker.cpp.o
1717
/Users/runner/work/KVIrc/KVIrc/src/modules/spellchecker/libkvispellchecker.cpp:29:10: fatal error: 'enchant-provider.h' file not found
1718
#include <enchant-provider.h>
1719
         ^~~~~~~~~~~~~~~~~~~~
ctrlaltca commented 2 months ago

Don't worry, it's a known problem, the fix is in https://github.com/kvirc/KVIrc/pull/2636 but i'm waiting for an ACK before merging it

ctrlaltca commented 2 months ago

Merged, thank you!