search

kvirc / KVIrc

The KVIrc IRC Client
http://www.kvirc.net/
GNU General Public License v2.0
237 stars 75 forks source link

make kvirc smarter with channel keys (+k) #416

Open DarthGandalf opened 9 years ago

DarthGandalf commented 9 years ago

Reported by g on 05 Apr 2009 07:10:38 UTC The ability of kvirc to store channel keys is implemented in the connection dialog for on-join channels. However, at all other times, when joining channels it won't use the keys stored in the connection dialog. Example: for server irc.efnet.org, #channel has key KEE stored in connection dialog. If channel is parted, and later rejoined, kvirc should reference this channel list for possible keys when attempting to join, this way the key will be always remembered.

Migrated from: https://svn.kvirc.de/kvirc/ticket/416

DarthGandalf commented 9 years ago

Modified by HelLViS69 on 19 Dec 2009 16:47:57 Version: 4.0 Insomnia → 4.0rc2 Insomnia

DarthGandalf commented 9 years ago

Modified by HelLViS69 on 02 Feb 2010 14:17:44 Version: 4.0rc2 Insomnia → 4.0 Insomnia

DarthGandalf commented 9 years ago

Modified by HelLViS69 on 27 Jun 2010 15:19:20 Version: 4.0 Insomnia → 4.1 Equilibrium

un1versal commented 8 years ago

imo this is a bug, making it a feature request is a cop out and a band aid to hide the real problem.

un1versal commented 8 years ago

Ive looked at the Join Channels Dialog implementation, it does have a password field which works when joining a channel + key...

However if you add a channel + key and press register the key value is not stored anywhere due to the way it was done...

Im not sure if Ill be able to fix this myself, but Ill try since I find this whole dialog somewhat unfit for purpose as is..

un1versal commented 8 years ago

What should happen is this

You connected to Network X and open Join channels dialog to join a channel with key via join channels dialog...

capture

because that doenst save keys at all when you press register and this just goes to some misterious place in kvirc heaven(or hell)

What should happen is when clicking register the entry is automatically added to the network (like below example) capture

un1versal commented 8 years ago

VFiber commented on 9 Feb

It might be two separate issue or one alone:

If I join a channel locked with a key and add that channel into auto-join, it does not add the key into auto-join. Gives a "cannot join due to lack of correct key" on startup and does not join to the keyed channel.

If I add the chan manually (with the key) it forgets between reconnects (does not save correctly?), and does not join either.

Windows 7x64, 10x64 KVIrc Aria 4.9.1, revision: git-6221-gc95fb88, sources date: 20160102, built on: 2016-02-08 02:09:09 UTC

Merged with https://github.com/kvirc/KVIrc/issues/1873 on Tue Jul 5 03:51:48 BST 2016

SoniEx2 commented on 9 Feb

Sounds like channels don't store keys, and so autojoin doesn't pick up on that. If you join any channel, without adding it to autojoin, and cause a reconnect, does it still rejoin? If so that rejoining part isn't related to autojoin. (I don't use KVIrc so I don't know :P)

VFiber commented on 9 Feb

Okay, whats weird it works now: it joins without a problem. My guess is: within session, some setting-save-load doesn't happen, but on quit it saves and during next startup it loads these settings correctly.

un1versal commented on 10 Feb

@VFiber theres quite a lot of issues with settings saving and a bug report for it. It makes me wonder if its related to the many coverity memory corruption that havent been fixed.