kvisle / oslo_waste

Home Assistant platform for garbage pickup schedule in Oslo
7 stars 3 forks source link

Stopped working yesterday! #4

Open oywino opened 3 years ago

oywino commented 3 years ago

I have had the oslo-waste integration running just fine for a long, long time (must be close to two years now). Yesterday it stopped working for no apparent reason;

image

I have not updated anything or made any other changes - what so ever. The only thing I do is that I restart HA from time to time when I have to. Everything else is still working just fine.

I run HA 2021.2.3 in a Docker Container.

kvisle commented 3 years ago

Have you double checked that the website which this plugin uses yield a proper result for your street?

You can verify this here:

https://www.oslo.kommune.no/avfall-og-gjenvinning/avfallshenting/

If your address isn't showing up, you should contact Oslo Kommune and make them put it back.

Addresses have been removed from the results before, and there's not much I can do about that.

If your address shows up properly, I will investigate further. If you want to share your address with me without posting it here - send me an email (check the commit logs for address).

oywino commented 3 years ago

My address shows up properly:

image

Here's my entry under sensors: in configuration.yaml :

#Avfallshandtering i Oslo
  - platform: oslo_waste
    address: 'MIDDELTHUNS GATE 19'
kvisle commented 3 years ago

Right. The sensor assumes that the "Neste tømming" column contains a parseable date - which it in this case does not.

I can't make the component return a valid countdown for you, but I'll look into improving its error handling.

oywino commented 3 years ago

Ok, but since it has worked perfectly for a long time, it must mean that the column always did contain a date in the past, right? So what could be the reason it has disappeared? Is it likely that this is just a temporary situation, and that in a couple of days it will return again, when Oslo Kommune discover that their web site is malfunctioning?

kvisle commented 3 years ago

Maybe.

But I've seen addresses disappear for a long time, so I suspect you may have to tell them.

oywino commented 3 years ago

Well, thank you. At least now I know what the problem is. But since you have experienced this before, perhaps its a good idea to include error handling code in the integration to prevent it from failing completely when this field is empty or contains an invalid date?

kvisle commented 3 years ago

Yes 🙂

oywino commented 3 years ago

After updating HA to 2021.6 the oslo_waste integration stopped working again. Configuration check now produce an error:

Configuration Invalid
Platform error sensor.oslo_waste - Integration 'oslo_waste' not found.

I haven't made any changes to either the _customcomponents folder content or the configuration.yaml file. I think this might be because custom integrations will require a version key in their manifest file as of 2021.6 Otherwise they will not load.

oywino commented 2 years ago

I decided to give your integration another try today after updating HA to 2022.7.5 but regretfully it fails with the following error in the log:

Error while setting up oslo_waste platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 250, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/oslo_waste/sensor.py", line 32, in async_setup_platform
    await ws.async_update()
  File "/config/custom_components/oslo_waste/sensor.py", line 59, in async_update
    for v in values:
TypeError: 'NoneType' object is not iterable

Any advise is appreciated.