kvj / hass_nuki_ng

Better support for Nuki devices in the Home Assistant
MIT License
185 stars 36 forks source link

Add doorbell suppression select #126

Closed moeffju closed 1 year ago

moeffju commented 1 year ago

This is a very quick and dirty, untested, first go at the code.

I don't have a full HA dev environment set up yet. I'll try to do that in the next days, but if there's someone else who wants to test this or correct obvious beginner's errors, have at it!

kvj commented 1 year ago

Actually looks good to me! But I don't have the opener, so it would be nice if someone with the device could test the branch. You could remove the switches I've added earlier for that field

moeffju commented 1 year ago

I'll try to get a test version deployed on my Home Assistant soon, I'm still recovering from The Covid rn.

Zrnoile commented 1 year ago

Can the option to press the bell on the opener be added? For example, to automate the camera's activation when someone presses the bell.

Se7enair commented 1 year ago

Can the option to press the bell on the opener be added? For example, to automate the camera's activation when someone presses the bell.

This should be already possible. There is a "ring action". Binary_sensor that turns on when the bell is ringing. I already use this to open the camera on my dashboard.

Se7enair commented 1 year ago

I'll try to get a test version deployed on my Home Assistant soon, I'm still recovering from The Covid rn.

Actually looks good to me! But I don't have the opener, so it would be nice if someone with the device could test the branch. You could remove the switches I've added earlier for that field

I have a opener and tested it. I just copied the changed files to my homeassistant and restarted.

Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:328
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 11:29:55 (1 occurrences)
Last logged: 11:29:55

[redacted] Unable to serialize to JSON. Bad data found at $.event.a.select.nuki_opener_ring_suppression.a.options=dict_keys(['Off', 'Ring', 'Ring to Open', 'Continuous Mode', 'Ring & Ring to Open', 'Ring & Continuous Mode', 'Ring to Open & Continuous Mode', 'On (suppress all)'])(<class 'dict_keys'>
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:254
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 11:30:41 (1 occurrences)
Last logged: 11:30:41

[redacted] Unable to serialize to JSON. Bad data found at $.result[234](State: select.nuki_opener_ring_suppression).attributes.options=dict_keys(['Off', 'Ring', 'Ring to Open', 'Continuous Mode', 'Ring & Ring to Open', 'Ring & Continuous Mode', 'Ring to Open & Continuous Mode', 'On (suppress all)'])(<class 'dict_keys'>
moeffju commented 1 year ago

Superseded by #146 thanks @GNeras