kvj / hass_nuki_ng

Better support for Nuki devices in the Home Assistant
MIT License
177 stars 34 forks source link

Opener - Ring suppression switch? #76

Open IrealiTY opened 2 years ago

IrealiTY commented 2 years ago

Hey :) Is there a way to create a switch that can toggle the ring suppression on the Nuki Opener?

Screenshot_20220718-114841

riddlenl commented 1 year ago

I am thinking about getting the Nuki Opener and this is a go/no-go thing having the option to suppress the ringer. So I'd be happy to have it installed soon and participate in testing. Also, does HA know when the doorbell has been pushed with this integration?

At the moment it is working, but with wrong settings. I use a web api call. So there is a way. And yes, the integration knows when the doorbell has been pushed.

Nice, given this integration will do what I want I'm gonna go with Nuki Opener instead of creating my own ESPhome solution and doing magic things to get everything to 3v.

Is there an event I put in an automation for the doorbell? I can't seem to find anything in the docs for this custom integration :)

I can test and try out some stuff after I install it, possibly Tuesday or Wednesday.

Edit: nvm, I just read through some topics, so I know how to setup automations. Thank you :)

Se7enair commented 1 year ago

@Se7enair I see where the problem is. The API field is a bit-mask so maybe I'm flipping the wrong bit.

I can replace the switch with select and expose all the combinations there

I dont want to annoy you, but did you already implemented it? My wife is complaining about the not working ring suppression ;)

moeffju commented 1 year ago

I just saw this issue while I was trying to have a go at implementing this. My naive approach was to add additional entities, for "Ring suppression" (bit 1), "Ring suppression (Ring to Open)" (bit 2), "Ring suppression (Continuous mode)" (bit 3), and "Ring suppression (all)" (bit 1 & 2 & 3).

@kvj I don't know if you had a chance to work on this, but I'm curious about your opinion either way, do you think it makes sense to have multiple switches for each state, or should I look into going the Select route? (I have no previous HA development experience.)

https://github.com/kvj/hass_nuki_ng/pull/126 is my first (very quick and dirty and untested) go at what a Select could look like.

Se7enair commented 1 year ago

In the nukiapp there are tree buttons. So buttons would be more "Nuki like". But I think the select-way is more convenient for the user and also for the dev. +1 for select ;)

moeffju commented 1 year ago

I mean technically nothing is stopping us from offering both... :D

zimjjan commented 1 year ago

@kvj can be closed