Make pp_sql work if rewrite_to_sql_method = false

kvokka / pp_sql

Rails ActiveRecord SQL queries log beautifier

MIT License

265 stars 9 forks source link

Make pp_sql work if rewrite_to_sql_method = false #19

Closed dputtick closed 4 years ago

dputtick commented 4 years ago

Second try at this! @kvokka sorry about #18, and sorry this took me so long to get back to. My fault for forgetting to run all of the tests one more time before pushing. I've added a few more tests this time, and they all pass :)

kvokka commented 4 years ago

@dputtick Thank you for your PR. Will be happy to merge after making hound happy (or pls describe why it's not possible)

dputtick commented 4 years ago

@kvokka ok, I think the things Hound flagged are fixed

kvokka commented 4 years ago

Grate! Thank u

kvokka commented 4 years ago

@dputtick Had to revert it, because of https://travis-ci.org/github/kvokka/pp_sql/builds/711223824 (and the error message shows that using old version of sqlite was on purpose).

Can you please take a look?

dputtick commented 4 years ago

I didn't realize how thorough the Rails/Ruby compatibility testing is! I'll try to see what's going on.