Another try: make pp_sql work if rewrite_to_sql_method = false

kvokka / pp_sql

Rails ActiveRecord SQL queries log beautifier

MIT License

265 stars 9 forks source link

Another try: make pp_sql work if rewrite_to_sql_method = false #21

Closed dputtick closed 4 years ago

dputtick commented 4 years ago

Going to open this as a draft and make sure CI passes!

dputtick commented 4 years ago

Ok, I think this time the build should pass 🤞. Here's a passing build: https://travis-ci.org/github/kvokka/pp_sql/builds/711507641. I think the tests were probably passing if you had a local Gemfile.lock with rails <6, but rails 6 and sqlite 1.3 seem incompatible, so they were broken when running rake test with a fresh install. I also added some instructions on how to use appraisal locally.

kvokka commented 4 years ago

Thank u for a great job, @dputtick ! merging 👍

dputtick commented 4 years ago

Thanks for being patient with the build issues!