search

kvosbur / SubRedditBackgroundImages

The idea behind this is to make a program that cycles through and sets your desktop background based off of popular wallpapers submitted to a subreddit of your choice.
0 stars 0 forks source link

Image selection doesn't always choose images of similar height #5

Closed kvosbur closed 4 years ago

kvosbur commented 4 years ago

This doesn't happen all the time but sometimes it seems that much smaller images are being chosen to be combined with larger images which shouldn't be allowed.

kvosbur commented 4 years ago

Example of 3 images chosen are /r/Animewallpaper/comments/eyskfp/kama_fategrand_order_2250x4000/ /r/Animewallpaper/comments/eysk8f/oda_nobunaga_fategrand_order_2250x4000/ /r/Animewallpaper/comments/eymbr5/rem_rezero_2812x5000/ the largest with a 5000 px height is higher than the allowed factor of 0.9 which would put allowed height to be at 4500.

kvosbur commented 4 years ago

Here is a list printed from memory of a portion where the largest image (5000 is always paired with 4000 height images. [ 0 URL: https://i.redd.it/jo7eoqh9gue41.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmp1pzpu8km.jpg Height:4000 , 1 URL: https://i.imgur.com/EutiMfe.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmp5f6y_hns.jpg Height:1920 , 2 URL: https://i.redd.it/99qky2zx6ve41.png FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpuhzixs6n.png Height:2436 , 3 URL: https://i.redd.it/fszcdofojue41.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpygv6w4d5.jpg Height:4000 , 4 URL: https://i.redd.it/wwt28ys8lue41.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpsdelpygb.jpg Height:4000 , 5 URL: https://i.redd.it/bmdk44wvmxe41.png FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmp911e7irh.png Height:4000 , 6 URL: https://i.redd.it/slraqbhomxe41.png FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpskxwav2f.png Height:4000 , 7 URL: https://i.redd.it/lzitvr0hxue41.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpad2hjl44.jpg Height:5000 , 8 URL: https://i.redd.it/olcckyd4iue41.jpg FilePath:C:\Users\kevin\Desktop\reddit_background\SubRedditBackgroundImages\PictureSource\tmpwzctljrr.jpg Height:4000 , ]

kvosbur commented 4 years ago

Fixed in #21