Add the ability to select Query options when looking up workout samples

kvs-coder / health_kit_reporter

A Flutter wrapper for the HealthKitReporter library

https://pub.dev/packages/health_kit_reporter

MIT License

38 stars 38 forks source link

Add the ability to select Query options when looking up workout samples #67

Closed SamBergeron closed 9 months ago

SamBergeron commented 1 year ago

Status

READY

Migrations

Description

This PR exposes the sample query options allowing us to use them in Flutter. This resolves issues that are outlined in #66

There should be no regressions here as all this does is add an extra option to the workoutQuery in the Flutter plugin, the native extensions have been updated to accept this new argument and match the style that is applied to other methods. There is no native plugin change required. This is reverse compatible.

SamBergeron commented 9 months ago

Bump! This is a pretty useful option that is backwards compatible! It'd be really nice to have this merged in so we don't have to keep using our fork of the plugin.

We've also noticed that the same issue happens with importing Sleep entries so we'll make an other PR soon enough with similar changes! Would be great if someone reviewed this