search

kvtools / valkeyrie

Distributed Key/Value Store Abstraction Library written in Go.
https://pkg.go.dev/github.com/kvtools/valkeyrie
Apache License 2.0
278 stars 43 forks source link

Modules: update etcd dep to v3.3.13 #28

Closed abronan closed 5 years ago

abronan commented 5 years ago

@victorcoder This updates the etcd dependency to v3.3.13.

In short, the current version pinned uses ugorji/codec and if running a project that uses both valkeyrie and embedded etcd (https://godoc.org/github.com/coreos/etcd/embed), and if that same project uses another dependency that itself requires ugorji/codec at a version incompatible with the pinned version, you won't be able to build the project (see https://github.com/etcd-io/etcd/issues/10325).

v3.3.13 removes the use of ugorji/codec and thus should help with those transient dependency issues with go modules.

Signed-off-by: Alexandre Beslic abeslic@abronan.com

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 84.168% when pulling da221fe61e719798302823f9d70dd9ea2425570f on update_etcd_dep into 20861cd6729e0d0bee391b220577b4d24490b787 on master.

abronan commented 5 years ago

@victorcoder Will get this one in if you don't mind the process skip. Not a huge change from a feature/usability PoV and will allow people to use valkeyrie with embedded etcd without the issue due to ugorji/codec.

vcastellm commented 5 years ago

@abronan sorry for the late response, LGTM