search

kvverti / colormatic

An independent implementation of the custom colors mod for Minecraft 1.15-1.18
GNU Lesser General Public License v3.0
108 stars 49 forks source link

Updated to 1.19.3 and fix some error (not working yet) #126

Open fedetrifo06 opened 1 year ago

fedetrifo06 commented 1 year ago

I updated the mod to Minecraft 1.19.3 but i can't compile it for some errors.

Anyone can fix it?

Rektroth commented 1 year ago

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

Rektroth commented 1 year ago

As it turns out, the preview versions of 1.19.3 OptiFine that are presently available do not currently feature colormapping, likely for this exact reason. Based on what I've seen trying to get it working, it's my opinion that colormapping will have to be completely overhauled.

fedetrifo06 commented 1 year ago

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

I know, but this is a start

extremepayne commented 1 year ago

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

Rektroth commented 1 year ago

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

mstreurman commented 1 year ago

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

Rektroth commented 1 year ago

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

I haven't actually looked further yet.

Honestly, given some of what we've seen in today's April Fools snapshot, combined with the fact that we have seen Mojang add April Fools features to the game before (see Coal Block snd Stained Glass), I'm hopeful custom colormapping in the vanilla game is coming in the near future. 🫰