search

kvverti / colormatic

An independent implementation of the custom colors mod for Minecraft 1.15-1.18
GNU Lesser General Public License v3.0
108 stars 49 forks source link

Add support for 1.19.3 #128

Closed mrjasonn closed 1 year ago

mrjasonn commented 1 year ago

It's crashing on 1.19.3 so need to update it to be compatible + realms now use 1.19.3 so need to update this mod. @kvverti

126 They made a usable version for 1.19.3 so can just merge pull request with (possibly) few changes.

TechPro424 commented 1 year ago

Yes please update

velnias75 commented 1 year ago

Made it at least compiling on 1.19.3, but currently the mixins are not ported. So it is not really tested yet, but with all - not yet working mixins - excluded the result looked already good.

@kvverti: You may use this as starting point? It already includes my path for #6 Here is my tag: https://github.com/velnias75/colormatic/tree/JustCompileOn-1.19.3 (on branch 1.19.3)

velnias75 commented 1 year ago

I got it to work so far, that at least Minecraft is playable in 1.19.3 Either @kvverti will fix the rest, or somebody will help me or take over my branch.

Current sources can be found here: https://github.com/velnias75/colormatic/tree/1.19.3

mstreurman commented 1 year ago

crash-2023-02-13_01.44.07-client.txt

Minecraft doesn't start with this new version of colormatic. Attached the crashlog

velnias75 commented 1 year ago

As I told, I need either help, ot @kvverti will may use it as starting point. I just tried to get it at least running on my PC.

mstreurman commented 1 year ago

As I told, I need either help, ot @kvverti will may use it as starting point. I just tried to get it at least running on my PC.

This was in no way an attack on you or saying you need to fix it, I just wanted to give feedback and a crashlog so there is more information available to work with.

RU-B0 commented 1 year ago

Just wanted to help out: 2 crashes, quilt (probs ignore) and fabric. They have the same error, compiled on my pc, here u go. No idea if this is useful but yk. FABRIC.txt QUILT.txt I got a window on each, white screen, then it instantly crashed with "The game crashed whilst initializing game Error: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1092 failed" I wish this mod was simpler so that it was easy to update...but i like the features... have a good day!

kvverti commented 1 year ago

Consolidating 1.20 update in #136