kvz / bash3boilerplate

Templates to write better Bash scripts
http://bash3boilerplate.sh
MIT License
2.13k stars 199 forks source link

close issue #108 #109

Closed mstreuhofer closed 6 years ago

mstreuhofer commented 6 years ago

alright. the issue 108 is fixed. that's a fact. travis would also agree that there are no errors- if the PR #99 and PR #102 wouldn't have been merged without a proper travis check at the time.

honestly i don't even see the point of the __invocation variable. maybe we should reconsider this line of code and its merge. looks like a very specific use case to me instead of appealing to all users. and even if all that would be no problem- the name is way to unclear.

anyway. i fixed the travis problem on linux machines by using cabal install shellcheck. it works but it causes shellcheck to be compiled and thus double the runtime of the acceptance tests.

kvz commented 6 years ago

Thanks a lot @mstreuhofer!

i fixed the travis problem on linux machines by using cabal install shellcheck. it works but it causes shellcheck to be compiled and thus double the runtime of the acceptance tests.

Perhaps we can improve this by adding some cabal cache directory to the travis cache dirs?

As for

maybe we should reconsider this line of code and its merge

I'm okay reconsidering that yes, perhaps we should have a separate issue where we discuss it's removal?

Merging this