kvz / bash3boilerplate

Templates to write better Bash scripts
http://bash3boilerplate.sh
MIT License
2.12k stars 198 forks source link

Fix or silence remaining warnings with shellcheck v0.7.0 #117

Closed lukasstockner closed 5 years ago

lukasstockner commented 5 years ago

SC2235: The warning/suggestion about the subshell was letigimate, so the suggested fix is implemented.

SC2034: The variable __invocation is indeed unused, but it's supposed to be there in case the script using bash3boilerplate wants to use it, so this commit silences the warning.

SC1102: The warning about the parsing of $((( is legitimate, so the suggested fix is implemented.

SC2015: While the warning is correct in general, here 'true' has no side effects hence it can be silenced.

Fixes #107.

kvz commented 5 years ago

Thank you!