search

kvz / bash3boilerplate

Templates to write better Bash scripts
http://bash3boilerplate.sh
MIT License
2.13k stars 199 forks source link

reduced usage of external sed + egrep #71

Closed mstreuhofer closed 7 years ago

kvz commented 7 years ago

Love this ❤️

Just some nitpicking about making regexes less eager, but feel free to merge already

mstreuhofer commented 7 years ago

anything else holding this PR from being merged?

zbeekman commented 7 years ago

@mstreuhofer

LGTM! 🎉 💯

I think you addressed @kvz's concerns adequately. Thank you for your contribution!!!