Issue 44 issue 21 issue 47

kvz / bash3boilerplate

Templates to write better Bash scripts

http://bash3boilerplate.sh

MIT License

2.12k stars 198 forks source link

Issue 44 issue 21 issue 47 #85

Closed zbeekman closed 7 years ago

zbeekman commented 7 years ago

Thanks for contributing to b3bp! As part of your PR, have you:

[X] Added an item in CHANGELOG.md with attribution?
[X] Added your name to the README.md
[X] Linted your code? (make test should do the trick)

Fixes #47 Fixes #44 Fixes #21

zbeekman commented 7 years ago

I untabbified main.sh and test/acceptance.sh and added poor-man's style enforcement regex to test/style.pl for checking for tab characters optionally mixed in with whitespace at the beginning of lines and for trailing whitespace.

zbeekman commented 7 years ago

@kvz I also enable weekly cron builds with travis to see if anything in the node/Travis-CI ecosystem changes and breaks our tests... not sure if this is possible/needed but thought that it couldn't hurt.

kvz commented 7 years ago

Nice work - merging 🎉

zbeekman commented 7 years ago

posting a new release anytime soon?

kvz commented 7 years ago

Will do so right now

kvz commented 7 years ago

Done