search

kvz / bash3boilerplate

Templates to write better Bash scripts
http://bash3boilerplate.sh
MIT License
2.12k stars 198 forks source link

fixup example.sh like 2.3.0 main.sh #87

Closed mstreuhofer closed 7 years ago

mstreuhofer commented 7 years ago

__i_am_main_script logic fixed for example.sh added double-sourced test

zbeekman commented 7 years ago

@mstreuhofer if you're finished, I propose I rebase #86 right onto this PR. What are your thoughts?

zbeekman commented 7 years ago

i'm done in this PR. if everybody agrees to the changes you can rebase your branch on mine and just merge yours after. this PR could then be closed.

@mstreuhofer Can I just add my commits to this PR? Because I think I have a fix for the MacOS build failures.... then we can just close one PR... I know @kvz is off enjoying his weekend already, and I don't see any reason why anyone would object to your proposed changes

zbeekman commented 7 years ago

I'm going to make this change and then cancel the jobs, except for the latest push and pr job

mstreuhofer commented 7 years ago

ok. i'll stay clear until the dust settled. good luck.

zbeekman commented 7 years ago

hmmmm I think https://github.com/kvz/bash3boilerplate/pull/87/commits/9c747d29b7d8907e839791c59779cec3dc59724d is not the fix... it's already listed in the dev dependencies... The issue may be that lanyon requires bundler which may be missing on OS X.... and of course the OS X CI queues are super backed up as always.

zbeekman commented 7 years ago

It looks like @kvz might be tweaking/fixing lanyon to resolve the OS X build failure... because I'm pretty flummoxed.

Save us, @kvz! lol

kvz commented 7 years ago

Trying @zbeekman! With a bunch of commits to master - for which I'm sorry, but I don't have a better way of debugging things on Travis that pass locally. (setting up a Travis VM locally is a bit beyond what I can invest atm).

kvz commented 7 years ago

Okay should be good @mstreuhofer @zbeekman (meaning: it's failing on this now: https://travis-ci.org/kvz/bash3boilerplate/jobs/201536450#L2779) - sorry for the delay!

zbeekman commented 7 years ago

thanks @kvz! Looking good. Not sure what that build failure was about, but the problem seems to have gone away... probably you were on a stale branch?

lekevbot commented 7 years ago

I think this very PR addressed it(?) my stuff was in master

On Tue, 14 Feb 2017 at 19:02, Izaak Beekman notifications@github.com wrote:

thanks @kvz https://github.com/kvz! Looking good. Not sure what that build failure was about, but the problem seems to have gone away... probably you were on a stale branch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kvz/bash3boilerplate/pull/87#issuecomment-279785588, or mute the thread https://github.com/notifications/unsubscribe-auth/ATIcHDCze7_k3duZNMbacQs9b2SPtOoMks5rcewjgaJpZM4L9xew .

-- Sent from mobile, pardon the brevity.