Enable color in screen or tmux

kvz / bash3boilerplate

Templates to write better Bash scripts

http://bash3boilerplate.sh

MIT License

2.12k stars 198 forks source link

Enable color in screen or tmux #92

Closed gmasse closed 7 years ago

gmasse commented 7 years ago

As screen (and tmux obviously) is now compiled with 256 colors most of the time, I have added the detection of these TERMs for auto-color feature

[x] Added an item in CHANGELOG.md with attribution?
[x] Added your name to the README.md
[x] Linted your code? (make test should do the trick)

zbeekman commented 7 years ago

Sweet! Any chance you could also do a search and replace on egrep → grep -E since shellcheck added this to their linter? (This is the only reason the test is failing, AFAICT)

zbeekman commented 7 years ago

Thanks for the contribution @gmasse! 🎉

zbeekman commented 7 years ago

@kvz what did I do that broke the build? I'm so confused why master is failing now.

kvz commented 7 years ago

Sorry about the delay here! It seems that Travis CI upgraded their node 6 version, but we have some binaries that needed to be rebuilt. Usually things always get rebuilt from scratch on Travis, but we cache the node_modules folder across builds to speed up build times. Meaning the newer Node version found old bindings and cowardly aborted with errors and such.

Fixed it via gem install travis && travis cache --delete && git commit --allow-empty -m 'Build plz' && git push

We could also consider not caching node_modules in .travis.ymlsince that will prevent this issue in the future, at the tradeoff of having slower build times 🤷‍♀️

zbeekman commented 7 years ago

ah, interesting. I had forgotten about the cache. You can also delete it via the web interface... I should have caught on that that was the problem when the PR build passed but post-merge failed. Thanks!