search

kvz / json2hcl

Convert JSON to HCL, and vice versa. We don't use json2hcl anymore ourselves, so we can't invest time into it. However, we're still welcoming PRs.
https://github.com/kvz/json2hcl
MIT License
498 stars 100 forks source link

Add support to automatically generate release, and upgrade go to 1.18.1 #21

Closed greatbody closed 2 years ago

greatbody commented 2 years ago

Add support to automatically generate release, and upgrade go to 1.18.1

This makes release easy.

Acconut commented 2 years ago

@rsun-thoughtworks (or @greatbody, not sure who of you is the author), if you are willing to make the changes mentioned in the comments, we could merge this.

greatbody commented 2 years ago

@Acconut I commited changes a few minutes ago. I think we can merge now.

greatbody commented 2 years ago

No sure if I need to close this PR and create another one?

mbevc1 commented 2 years ago

Not sure you'd need a new one. @Acconut would need to review this again

mbevc1 commented 2 years ago

Could we please cut a new release now including those changes?

Acconut commented 2 years ago

New release is available: https://github.com/kvz/json2hcl/releases/tag/v0.1.1 Thanks for the help!