search

kvz / json2hcl

Convert JSON to HCL, and vice versa. We don't use json2hcl anymore ourselves, so we can't invest time into it. However, we're still welcoming PRs.
https://github.com/kvz/json2hcl
MIT License
488 stars 99 forks source link

Add Dockerfile #9

Closed miked0004 closed 6 years ago

miked0004 commented 6 years ago

Basic Docker wrapper of json2hcl.

miked0004 commented 6 years ago

I require no attribution. Just adding this because I found it useful. Feel free to grab the Dockerfile and reject the PR, if you find it useful.

kvz commented 6 years ago

I wonder why this is useful when you can have a go binary for every platform without containerizing it? Honest question this!

Acconut commented 6 years ago

why this is useful when you can have a go binary for every platform without containerizing it?

I assume that you can run the binary from source code but don't have to install Go? But that's just a guess.

miked0004 commented 6 years ago

Ok, thanks for the consideration. Just an offer.

kvz commented 6 years ago

I guess we don’t auto build cross platform binaries for releases like we do for tusd. But if we set that up, what would the purpose for docker be for a cli tool @acconut?

Sent from mobile, pardon the brevity.

On 20 Feb 2018, at 02:21, miked0004 notifications@github.com wrote:

Closed #9.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Acconut commented 6 years ago

We do build cross platform binaries for all common platform already, for ever release. For example: https://github.com/kvz/json2hcl/releases/tag/v0.0.6

kvz commented 6 years ago

I see, so that circles us back to the question, why would docker be useful for cli tools if you already had binaries available for each platform. Serious question. I guess containing memory usage or privileges might be easy/er with it. Yes, I guess you could be sure it could not temper with files in your home dir unless you explicitly mapped volumes?

Sent from mobile, pardon the brevity.

On 20 Feb 2018, at 19:15, Marius notifications@github.com wrote:

We do build cross platform binaries for all common platform already, for ever release. For example: https://github.com/kvz/json2hcl/releases/tag/v0.0.6

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Acconut commented 6 years ago

As I said above my thought is that you can build it from source (no untrusted binary to download) without install Go, which is not the easiest installation process. But that's just a guess.

kvz commented 6 years ago

Ah right, to run the sources directly, missed that part sorry! 👌