search

kw / camp

Larp Campaign Manager
MIT License
0 stars 1 forks source link

Created models.py in accounts #53

Closed brianefurlong closed 1 year ago

brianefurlong commented 1 year ago

Closes https://github.com/kw/camp/issues/6

Created Membership model in accounts.models. Created paths for Membership views in accounts.urls. Added views for Membership CRUD. Created templates for Membership CRUD.

brianefurlong commented 1 year ago

@kw Hey I made changes in response to your above comments. Please take a look and let me know what you think!

brianefurlong commented 1 year ago

Heads up in accounts.models.py:

Line 7 has a comment to make isort stop trying to move it above the import in line 5. When it does that, it results in a circular import. Is there a way to prevent the circular import?

kw commented 1 year ago

Heads up in accounts.models.py:

Line 7 has a comment to make isort stop trying to move it above the import in line 5. When it does that, it results in a circular import. Is there a way to prevent the circular import?

That one is my fault. I've corrected the circular dependency on my main branch. If you merge or rebase you should get the fix, though feel free to leave it as-is for now.

brianefurlong commented 1 year ago

Changes in response to above comments committed.

brianefurlong commented 1 year ago

Changes in response to above comments committed.