search

kw1jjang / CalVoD

CalVoD
http://www.eecs.berkeley.edu/~kw1jjang/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

video file name cannot contain "_" #13

Open chenjiayuan opened 8 years ago

chenjiayuan commented 8 years ago

If a video file has an underscore in its name (e.g. sample_video.flv), after running python encode_new.py sample_video.flv the encoder will convert underscore to dash in the output chunked files ("sample-video.1.dir" instead of "sample_video.1.dir")

This seems an easy fix Apart from the discrepancy between original video name and chunked video names, the write_csv method is being affected, however we are not going to use csv to store video info in the future

ryankashi commented 8 years ago

In other parts of the code, it uses '' as a delimiter to split things. If there is an "" in the name of the video, it screws this stuff up, so that's why inside of the encode_new.py it changes it. So we should keep it as it is!

chenjiayuan commented 8 years ago

I was fully aware of that, and understand that the current code is a work around. There might be an improvement that we can come up with