fix: Fix issue https://github.com/kwado-tech/l10n_mapper/issues/25

kwado-tech / l10n_mapper

MIT License

4 stars 2 forks source link

fix: Fix issue https://github.com/kwado-tech/l10n_mapper/issues/25 #28

Closed CaoGiaHieu-dev closed 1 month ago

CaoGiaHieu-dev commented 1 month ago

Description

Please check the following boxes

[ ] Pull Request title is consistent with the implemented feature, fix etc.
[ ] I have followed proper descriptive code style and conventions
[ ] The code is self-documenting and has no unnecessary comments. I named the functions and variables to clearly describe their purpose.
[ ] I have added Unit Tests and coverage is 70%+
[ ] I have tested and verified this implementation and it works as expected

CaoGiaHieu-dev commented 1 month ago

@kwado-tech hi . can you take a look on this pr ? Im try to fix issue #25 in this commit

kwado-tech commented 1 month ago

Hey @CaoGiaHieu-dev this pr does not clearly address the issue as there could be multiple cases of malformed translation keys and placeholders with case-format not compatible with darts file-generator.

Will push a fix to address the translation keys and placeholder as well

kwado-tech commented 1 month ago

Ticket resolved in https://github.com/kwado-tech/l10n_mapper/pull/29