search

kwannoel / urban-octo-carnival

DRAFT REPO: trying out gitlab -> github
Apache License 2.0
1 stars 0 forks source link

Document parser datatypes, more parser unit tests - [merged] #361

Closed kwannoel closed 2 years ago

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 23, 2021, 04:48

_Merges alexknauth/newTestparser -> master

Based on @pleger's branch pleger/newTest_parser

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 23, 2021, 22:29

added 6 commits

Compare with previous version

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 23, 2021, 23:43

added 1 commit

Compare with previous version

kwannoel commented 2 years ago

In GitLab by @isd on Jun 24, 2021, 01:16

Commented on compiler/parse/t/expressions-test.ss line 91

It looks like st is unused here (except in the commented out code).

kwannoel commented 2 years ago

In GitLab by @isd on Jun 24, 2021, 01:16

Commented on compiler/parse/t/expressions-test.ss line 48

These are much more readable than the tests above, is there a reason for using let* and so many intermediate variable names, rather than comparing whole expressions as you do here?

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:25

Commented on compiler/parse/t/expressions-test.ss line 48

Oh yes, the reason is the intermediate variable names were written before I fixed the transparentness bug in the structures. I can fix them now that that's done.

kwannoel commented 2 years ago

In GitLab by @isd on Jun 24, 2021, 01:34

Commented on compiler/parse/t/expressions-test.ss line 48

Quoting Alex Knauth (@AlexKnauth) (2021-06-23 13:25:43)

Oh yes, the reason is the intermediate variable names were written before I fixed the transparentness bug in the structures. I can fix them now that that's done.

That makes sense, please do.

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:48

Commented on compiler/parse/t/expressions-test.ss line 91

changed this line in version 4 of the diff

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:48

added 1 commit

Compare with previous version

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:48

Commented on compiler/parse/t/expressions-test.ss line 48

Okay, I've pushed this change.

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:50

Commented on compiler/parse/t/expressions-test.ss line 91

Since I've removed the need for these intermediate variables, st is gone and the body-expression-statements are tested by structural equality of the outer body instead.

kwannoel commented 2 years ago

In GitLab by @AlexKnauth on Jun 24, 2021, 01:50

resolved all threads

kwannoel commented 2 years ago

In GitLab by @isd on Jun 24, 2021, 04:39

approved this merge request

kwannoel commented 2 years ago

In GitLab by @isd on Jun 24, 2021, 04:39

mentioned in commit a9f51e6725901e18cf72a14330adc56e1510cfca