search

kwannoel / urban-octo-carnival

DRAFT REPO: trying out gitlab -> github
Apache License 2.0
1 stars 0 forks source link

Default initial-block-number to current-block-number - [merged] #383

Closed kwannoel closed 3 years ago

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 11, 2021, 02:47

Merges kwannoel/default-block-number -> master

Defaults the initial-block-number to current-block-number, instead of terminating the entire interaction.

kwannoel commented 3 years ago

In GitLab by @plotnick on Sep 11, 2021, 03:47

Commented on cli/interaction.ss line 206

Couldn't we call ask-number here? That way the underlying logic is only in one place.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 11, 2021, 05:23

Commented on cli/interaction.ss line 206

Yes, ask-number is not used anywhere else it seems.

On top of that I think the program should also error out if the input is non-empty and not a number.

The default case should only hold when input is empty.

Will fix these.

kwannoel commented 3 years ago

In GitLab by @fahree on Sep 13, 2021, 05:10

Commented on cli/interaction.ss line 215

Call it default- instead of def- characters are cheap, whereas ambiguity with define isn't.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 14, 2021, 00:45

Commented on cli/interaction.ss line 206

changed this line in version 2 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 14, 2021, 00:45

Commented on cli/interaction.ss line 206

changed this line in version 2 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 14, 2021, 00:45

Commented on cli/interaction.ss line 215

changed this line in version 2 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 14, 2021, 00:45

added 3 commits

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @fahree on Sep 14, 2021, 05:33

approved this merge request

kwannoel commented 3 years ago

In GitLab by @fahree on Sep 14, 2021, 05:33

LGTM.

If there's extra functionality you want, it's fine to add a TODO... technical debt!

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 15, 2021, 01:58

resolved all threads

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 15, 2021, 01:59

mentioned in commit 311b8076db82784c3fd4cecf9d69fa5165ec4982