kwartzlab / kos-base

KwartzlabOS
4 stars 1 forks source link

Remove tool authorizations (training and trained) and team membership for withdrawn members #54

Open sarahjonesmilligan opened 4 months ago

sarahjonesmilligan commented 4 months ago

(May need some discussion first on what the process should be)

Currently, withdrawn members must be manually removed from trainers and trainees on tools and there doesn't appear to be a mechanism for managing team members (or maybe because I'm not a listed as a team lead)

Instead, withdrawn members should be revoked as trainers and trainees and no longer listed on a tool's page. Withdrawn members should be removed from teams.

azend commented 4 months ago

If a member leaves and then rejoins, do they do training again? If so, we can remove the relations. Otherwise we can keep the relations to retain history but hide them from the list of trainers/trainees.

sarahjonesmilligan commented 4 months ago

I think the default would be yes to retrain, or allow each group of trainers decide on a case by case basis if it needs to be repeated (so remove them as authorized to use, then trainers can choose to re-add without meeting in person but at least it would force the decision). If someone withdrew for 3 months and came back, I could see them being asked to be retrained on the laser if it had been years since their original training but be reauthorized on the woodshop sanders for example as they're easier to operate.

mbells commented 4 months ago

I like retaining history, but also keeping the database simple and forcing a manual decision. Perhaps when a member withdraws, then we generate deactivation records (only look at the newest relation). The trainers for each particular area could then see the history and decide whether to reactivate or require a retraining.

This could also work if for example we upgrade a tool much or replace it, then all users could be deactivated until retrained...

azend commented 4 months ago

Hmm. It could get confusing for admin and members alike reviewing the system because membership lineage is tracked but relation to tools is not.

I think I also point towards simple on this one where a member is expected to retrain on membership re-activation. Then depending on the circumstances presented to the board, they can manually re-apply already trained tools.