kwartzlab / kos-base

KwartzlabOS
4 stars 1 forks source link

no "date joined" shown in directory if member was set to abandoned and then accepted #6

Open john-potts opened 2 years ago

john-potts commented 2 years ago

That's the presumed issue causing Christie Wood to not show a "date joined" in the directory list.

The rule about "one month to accept and start paying then we set your application as abandoned" is mostly to just have some sort of cutoff, and is not firmly enforced. So, Christie Wood's application was set to "applicant [abandoned]", and then later to active.

I haven't messed around with other abandoned applicants to try to duplicate the issue, though we probably could if needed.

Priority is pretty low, but we do sort the directory by date joined to check we haven't missed any process steps for any recent members.

azend commented 6 months ago

@john-potts wouldn't the intent here be to have the member re-interview? In which case a new user is created. So the old user can be left dormant with the user status remaining as abandoned. The new user can go through the normal interview and approval process.

azend commented 6 months ago

I'm going to pre-emptively mark this as #wontfix. We can continue to discuss but it sounds like this use case is outside the design intent of the membership application process.

readysteadywhoa commented 6 months ago

The purpose of the status timeline is to show the member's entire history with the organization (including when they apply, leave and come back, if they were previously suspended, etc.), this is why the same user account is used instead of creating a brand new one when someone returns. The statuses with the [reason] tags were implemented mainly for information at the time and probably needs additional logic to handle properly in the member directory. It's an edge case that probably didn't exist when originally tested.

azend commented 6 months ago

Hey Ben. I agree and would expect as well that lineage would be retained. The part that I'm lost on is the expectation that, per business rules, abandoned or declined members must re-interview. But if they re-interview, then the system currently requires creation of a new user to capture the form data again. Any input to that? If the business rules are actually different, I don't see any problem with further pursuing this issue.

readysteadywhoa commented 6 months ago

Yes they do need to re-interview for our business rules, but kOS may not have all the logic to handle those extra statuses that have [reason] in them -- for example the code in the membership app that checks for previous users might not know what to do with a user with a Applicant [Abandoned] status. We should examine how those statuses are currently handled and make sure they're included in relevant logic.