search

kwaschny / unwanted-twitch

Hide unwanted streams, games, categories and channels on: twitch.tv
https://kwaschny.net
MIT License
102 stars 13 forks source link

New permission: "Read your browsing history" #2

Closed Dgc2002 closed 6 years ago

Dgc2002 commented 6 years ago

I was just notified that this extension needed permission to read my browsing history, which kind of crosses a line IMO.

I see you added tabs as a permission in 52dd39ec which is what triggered it(had to check the permission warnings list to figure out that was the cause).

IMO it'd be best to avoid that kind of thing as it will cause a lot of privacy minded people to remove the extension.

Zigsaw commented 6 years ago

Such as me (already removed it). Please undo that.

Edit: Installed the extension again.

kwaschny commented 6 years ago

Sorry, that was unintended. The "tabs" permission is required for Firefox to get all twitch.tv tabs. However, Chrome doesn't need this permission and shows a warning. I just removed the permission in the Chrome manifest, see: 7c7484917766956569438d2cf7e37ad0ba3d374b

kwaschny commented 6 years ago

I also adjusted the Firefox part to not require the "tabs" permission. I can see why people think it's fishy. Let's not change any permission without double checking it ever again. FeelsBadMan