search

kwaschny / unwanted-twitch

Hide unwanted streams, games, categories and channels on: twitch.tv
https://kwaschny.net
MIT License
104 stars 13 forks source link

Extension not working on Waterfox? #3

Closed notNSANE closed 6 years ago

notNSANE commented 6 years ago

Hi, I tried this extension on latest Waterfox portable: https://storage-waterfox.netdna-ssl.com/releases/win64/portable/WaterfoxPortable_56.2.2_English.paf.exe

But nothing appears on the address bar or on Twitch.

Maybe it's just incompatible with this version which is using an old Firefox source?

kwaschny commented 6 years ago

Waterfox doesn't support page_action.show_matches yet, which is required to detect if a tab is on twitch.tv and make the extension do its work.

Reading manifest: Error processing page_action.show_matches: An unexpected property was found in the WebExtension manifest.

The first version (source code) was working with the tabs permission to detect twitch.tv instead of relying on page_action.show_matches. And although this old version properly loads in Waterfox, there seem to exist other issues.

Sorry to say, but there's little reason for me to support older Gecko engines.

notNSANE commented 6 years ago

No probs! I understand why you don't want to support it. Interesting issue, I though they could be applied globally. I guess I should wait for Waterfox to upgrade.

Cheers and thanks for this extension!