search

kwaschny / unwanted-twitch

Hide unwanted streams, games, categories and channels on: twitch.tv
https://kwaschny.net
MIT License
104 stars 13 forks source link

Tags filtering is broken #60

Closed Luneyes closed 3 years ago

Luneyes commented 3 years ago

Hi! The tag filtering completely broke recently even though channels and categories one still work flawlessly. It seems like Twitch changed their code again. :/

This extension is awesome, thank you for your hard work!

kwaschny commented 3 years ago

Are you using Chrome and the most recent UTTV version 21.5.22? What exactly broke? Does it show the X buttons? Or does it just not remove items with blacklisted tags? What views are affected? Example links and screenshots help.

Luneyes commented 3 years ago

Sorry for the lack of details, let me fix that!

I'm using Firefox. Version is 21.3.21 (up to date according to Firefox's store).

What isn't working:

What works:

Here is a screenshot on a Game view (https://www.twitch.tv/directory/following/games) where tags filtering doesn't work and X button doesn't show up: Untitled

Here is a screenshot of Categories (https://www.twitch.tv/directory), everything work as intended: Untitled2

Luneyes commented 3 years ago

Wait... something is wrong. Apparently the tags X buttons sometimes work and sometimes don't...? I tried refreshing some pages and they showed up, and on some other pages they disappeared. It seems quite random for the buttons, but the filtering never seem to work for tags though.

I've got no other extensions that can interfere, I disabled all others just in case for the test. Any ideas of what could cause this? Anything you want me to try?

kwaschny commented 3 years ago

I'm using Firefox. Version is 21.3.21 (up to date according to Firefox's store).

You are still using the old/outdated version. The most recent version is 21.5.22. Unfortunately all Firefox and Edge users will have to wait a few more days before the update is officially available via browser store, i. e. automatic update. I'm sorry for making you write down everything in detail in this case. Let me tell you, this is still an excellent bug report. Thank you for your time. I added a quick solution at the bottom of this post, if you don't want to wait for the official store release.

For future reference, I will explain the flow in detail:

tl;dr

When I release a new version here on GitHub, it is not immediately available in the browser stores. And even once the stores serve the updated version, your browser still might not immediately update to the newest version.

This extension's code is shared between Chrome/Edge and Firefox. When I push a new version (see commits), I publish the package via Chrome Web Store, Edge-Add-Ons (both package "chrome") and Firefox Add-ons (package "firefox"). These stores have slightly different review policies to protect users against harmful software (and privacy violation). Firefox has historically been the fastest to automatically accept updates to existing extensions (usually less than 15 minutes), followed by Chrome (usually less than 3 hours) and Edge being the slowest (up to 10 days) due to manual/human review.

However, one of Mozilla's editorial managers (responsible for Firefox Add-ons) has recently informed me that they did a security code review, decided the extension is "trustworthy" (no warning about 3rd party extension on the store page) and will now require all new updates to be reviewed manually/by a human first. The reason is a marketing campaign to promote interesting extensions for Firefox. And they consider UTTV to be a candidate, which is really cool.

The downside is: It now takes even more time on Firefox to react to changes on twitch.tv. It takes time to:

You can fast-forward the whole situation by installing the extension manually for the time being. It's pretty easy to do on Firefox:

Luneyes commented 3 years ago

Wow thank you for your precise answer, that's amazing! Sadly Firefox disabled the possibility to add non-verified addons since v44 (even by editing stuff in the config page), so it's not possible anymore to install any addons that don't come from the store. I guess I'll wait for the store to catch up. ¯\ (ツ)/¯

PS: I'm stealing that bug report meme for later, it's very accurate. :D

kwaschny commented 3 years ago

Firefox disabled the possibility to add non-verified addons [...]

Oh true, it only works with about:debugging#/runtime/this-firefox and then load it as temporary add-on. That's bit too inconvenient for daily use, I guess.

Luneyes commented 3 years ago

I can confirm it's fixed on a temp debug addon! Thank you so much for your time and your help, what this extension does should be default features imo.