search

kwaschny / unwanted-twitch

Hide unwanted streams, games, categories and channels on: twitch.tv
https://kwaschny.net
MIT License
104 stars 13 forks source link

Custom tag case sensitivity #93

Closed Fusha closed 2 years ago

Fusha commented 2 years ago

Twitch has custom tags now, so it would make sense for the tag filter to be case insensitive. Right now, case sensitivity works weird: if I filter «PNGtuber» by clicking on the x next to the tag, «PNGtuber» will be hidden, but «pngtuber» will still show. But if I filter «pngtuber», both «PNGtuber» and «pngtuber» and all other case variations will be correctly hidden.

kwaschny commented 2 years ago

All blocked terms are supposed to be case-insensitive, so that's a bug then. I'll check it.

kwaschny commented 2 years ago

This has been addressed with 25def56a98cd64b515e8bd134319c3f0a1f57bf7. I also decided to normalize blocked terms and ignore diacritics in them. This will make it less likely to encounter "didn't I already block this?!" moments, hopefully.

Fusha commented 2 years ago

Works like a charm now, thank you for your work!

sublimal commented 2 years ago

I believe this update broke regular expressions and/or case-sensitive matching input. If I add /^[^a-z]+$/I what is stored is /[a-z]+$/i image

I'm also unable to add a literal '^' to any blacklist

kwaschny commented 2 years ago

Regression bug caused by 25def56a98cd64b515e8bd134319c3f0a1f57bf7.

kwaschny commented 2 years ago

Fixed with 932c7ef90130af31becdd2d2b9a84d0ddb6bc1ee.

kwaschny commented 2 years ago

Fixed in version: 22.11.3