search

kwelch / babel-plugin-captains-log

Babel plugin that injects helpful details into console statements
MIT License
85 stars 5 forks source link

Performance concerns #21

Open houshuang opened 6 years ago

houshuang commented 6 years ago

Seems like there might be some performance concerns with this plugin, as suggested by the Meteor team: https://github.com/meteor/meteor/issues/9884#issuecomment-388908957

kwelch commented 6 years ago

Thanks, for the heads up. I have not used it at scale. If I am reading your last comment on that thread properly the performance is different depending on the version of babel you all are using. Is that correct?

I have not played with this in a larger project nor have I used it with babel@>=7

I will try to get some time together to move this to babel@>=7. Additionally, I will pull down meteor and debugging it directly.

I am heading out of town this week, but I will do my best to at a minimum get this working with babel@7 in hopes that helps the perf.

kwelch commented 6 years ago

I have made the updates to reduce the number of arrays used to reduce garbage collection.

The latest release 1.1.0, have these updates.

If you can try it again to let me know if it there are still issues that would be great.

There were other items brought up in that thread, but removing the path.get calls would take a larger refactor so I would prefer to attempt a smaller fix first.

Thanks!