kwerle / ide-ruby

Atom package used to integrate https://github.com/kwerle/ruby_language_server with Atom. Development happens on the develop branch. Production is master.
23 stars 6 forks source link

Support project .rubocop.yml #11

Closed replygirl closed 6 years ago

replygirl commented 6 years ago

it would b very nice if we could disable specific annotations in settings. like, i'd love to just ignore all of rubocop's class & method length hints but keep the rest

kwerle commented 6 years ago

Nice name :-)

Pretty sure you can just by adding a rubocop config file to your project - cause they made me crazy, too. I'll try to confirm that later, today.

kwerle commented 6 years ago

Oh. Nope. That is in the plan, so I'll keep this open.

dbourguignon commented 6 years ago

@kwerle you mean there is no way to use a local .rubocop.yml at the moment?

kwerle commented 6 years ago

That is correct. For what it's worth, this is my "top priority". Dammit. I'll make a real effort to put some time in on it this week.

On Tue, Mar 20, 2018 at 1:35 AM, David Bourguignon <notifications@github.com

wrote:

@kwerle https://github.com/kwerle you mean there is no way to use a local .rubocop.yml at the moment?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kwerle/ide-ruby/issues/11#issuecomment-374515461, or mute the thread https://github.com/notifications/unsubscribe-auth/AABbGARUM3q-_3GHWVmmLxeizkHXegC2ks5tgL9YgaJpZM4R81B- .

-- kurt@CircleW.org https://kurt.CircleW.org/

kwerle commented 6 years ago

OK - pushed out a tweak. Hopefully .rubocop.yml in project root will have affect.

kwerle commented 6 years ago

(please let me know if it does/not work)

dbourguignon commented 6 years ago

@kwerle seems to work :) Thanks a lot

johnschult commented 5 years ago

Although it reads the project .rubocop.yml file now, it only reads it when the editor or the project is opened. It does not detect changes in the file and apply them to the running rubocop. The Diagnostics are not updated or reprocessed with the current cops if any changes are made to the file.

kwerle commented 5 years ago

Known issue.