search

kwhinnery / Helium

Unmaintained - check out github.com/appcelerator/alloy instead
http://www.appcelerator.com
Other
135 stars 21 forks source link

Fixed 'he.create' to accept sub Ti.UI namespaces as Ti.UI.iPad, iOS, Android... #2

Closed jipiboily closed 13 years ago

jipiboily commented 13 years ago

Hi, I fixed 'he.create' to accept sub Ti.UI namespaces as Ti.UI.iPad, iOS, Android. That said, I only tested it for iPad ns.

Wish you love it!

By the way, if I ever do a "pull request" with inapropriate code performance wise, let me know!

Jean-Philippe Boily

jipiboily commented 13 years ago

Forgot to tell how to use it.

Pretty simple sample: he.create('iPad.SplitWindow')

jipiboily commented 13 years ago

Going to check for those test. Are you assuming people are using Helium for iOS development? To test that, I need to test iOS, iPad or Android, there is no cross-platform sub Ti.UI namespace.

What is your point of view on that?

Thanks!

kwhinnery commented 13 years ago

I am assuming people are using Helium for cross-platform development, definitely. I hadn't included the sub-namespaces, but if I did, this is basically how I thought I would do it. When you write the test case, you would need to put conditional logic in your test to detect the current platform, and make assertions based on that. Should be pretty trivial. If you don't do it, I probably soon will. But i'd like it if you could do it ;)

jipiboily commented 13 years ago

I'll do it, just don't know when exactly. I'll be away from my computer for like 10 days. Might do it on january 4 or around...

If there's no stress on your side, let me do it!

Happy holidays!

jipiboily commented 13 years ago

Closing this request and opening a new one.