search

kwhinnery / todomvc-plusplus

TodoMVC++ Sample Application
MIT License
93 stars 148 forks source link

Uglify JavaScript during build process #3

Closed kwhinnery closed 8 years ago

kwhinnery commented 8 years ago

When we build static assets for production, we currently minify CSS but don't compress our javascript. We should uglify our JavaScript using Grunt, and add that to the collect_static task.

maurop123 commented 8 years ago

Do you want to not include sourcemaps?

kwhinnery commented 8 years ago

Not in the uglified version, as the intent here is to use this asset in production. If it was included, it would need to be external rather than inline in a comment.

kwhinnery commented 8 years ago

Not including sourcemaps at all would be fine.

bganicky commented 8 years ago

I don't know how to do a pull request when I already made one in the second issue and am now a one commit ahead. :) Is there a way do that?

maurop123 commented 8 years ago

https://github.com/kwhinnery/todomvc-plusplus/pull/24

Solved with src and dest and app.min.js