kwhinnery / todomvc-plusplus

TodoMVC++ Sample Application
MIT License
93 stars 148 forks source link

Add an npm script as a shortcut for the Sequelize migrate command #5

Closed kwhinnery closed 8 years ago

kwhinnery commented 8 years ago

In case someone doesn't have the Sequelize CLI installed globally, it would be nice to be able to at least execute the migrations for the app without installing sequelize-cli globally. Create an npm script that accomplishes this task. Then, create a Grunt shell command which executes this script.

There might be something there already that does this as part of the startup process, but let's make a special purpose npm script.

JamesMGreene commented 8 years ago

@bganicky Looks like there is another part of this issue that your PR has not addressed yet:

Then, create a Grunt shell command which executes this script.

JamesMGreene commented 8 years ago

@bganicky Actually, your PR does not accomplish this part of the issue either:

In case someone doesn't have the Sequelize CLI installed globally, it would be nice to be able to at least execute the migrations for the app without installing sequelize-cli globally.

:confused:

anthonybrown commented 8 years ago

did this get fixed, I had to run an errand

bganicky commented 8 years ago

@JamesMGreene Forgot about the Grunt task, but the second concern should be ok because if you run "sequelize" from npm script, it should use the project's one in "node_modules/bin" instead the global one. But I messed upped the pull requests anyway. :)