[#17] Allow manually sending "body" in request init - Githubissues

kwhitley / itty-fetcher

An even simpler wrapper around native Fetch to strip boilerplate from your fetching code!

MIT License

99 stars 4 forks source link

[#17] Allow manually sending "body" in request init #18

Closed danawoodman closed 2 years ago

danawoodman commented 2 years ago

Other changes:

Add test for changing content-type via request init to verify behavior.
Change vitest test environment to jsdom. This removes the need for importing isometric-fetch and brings the test env closer to the DOM which seems a safe baseline test env.

Closes #17

kwhitley commented 2 years ago

Merging this is a work-off point for a PR to modify behavior...

kwhitley commented 2 years ago

Gonna add a few bytes, but hopefully only temporarily

danawoodman commented 2 years ago

@kwhitley just curious, whatcha gonna change?

kwhitley commented 2 years ago

not embedding application/json by default (to allow blobs to override it)
not stringifying if instanceof FormData || Blob

Couple tests will have to change, but, although a breaking change (yay for pre-release), no one's code should really break

kwhitley commented 2 years ago

Something like this...

kwhitley commented 2 years ago

would have used passthrough on the body: ... line too but was getting a TS error I was too impatient to sort through, lol