search

kwhitley / itty-fetcher

An even simpler wrapper around native Fetch to strip boilerplate from your fetching code!
MIT License
99 stars 4 forks source link

Pass payload data to query params for GET requests #6

Closed danawoodman closed 2 years ago

danawoodman commented 2 years ago

Added tests. Note that I had to move the tests into a beforeEach so I can assert against the calls otherwise I get all them mock calls in the test.

Adds about 110 bytes, not sure if it is possible to reduce further.

kwhitley commented 2 years ago

Added tests. Note that I had to move the tests into a beforeEach so I can assert against the calls otherwise I get all them mock calls in the test.

Adds about 110 bytes, not sure if it is possible to reduce further.

Once it's merged, and we have test coverage, we can play further for byte-shaving :)

danawoodman commented 2 years ago

@kwhitley I added tests for the changes, did you see something missing?