search

kwhitley / itty-router

A little router.
MIT License
1.75k stars 78 forks source link

Typescript errors #51

Closed mkhattab closed 3 years ago

mkhattab commented 3 years ago

Hi, the latest changes in 2.4.0 produced the following typescript errors:

../../node_modules/itty-router/dist/itty-router.d.ts:16:6 - error TS2314: Generic type 'RouteHandler<TRequest>' requires 1 type argument(s).

16   2: RouteHandler[]
        ~~~~~~~~~~~~

../../node_modules/itty-router/dist/itty-router.d.ts:25:19 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

25   arrayBuffer?(): Promise
                     ~~~~~~~

../../node_modules/itty-router/dist/itty-router.d.ts:26:12 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

26   blob?(): Promise
              ~~~~~~~

../../node_modules/itty-router/dist/itty-router.d.ts:27:16 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

27   formData?(): Promise
                  ~~~~~~~

../../node_modules/itty-router/dist/itty-router.d.ts:28:12 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

28   json?(): Promise
              ~~~~~~~

../../node_modules/itty-router/dist/itty-router.d.ts:29:12 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

29   text?(): Promise
              ~~~~~~~

tsc --version

Version 4.3.5
kwhitley commented 3 years ago

Thanks for the heads up! Will clear those today :)

kwhitley commented 3 years ago

@mkhattab mind confirming that 2.4.1 fixes this issue? :)

mkhattab commented 3 years ago

@kwhitley just confirmed the fix, thanks!